Sign Up! Login: Password: New User? Forgot? Support
Top Mods!
Wowhead Search
by sonofsamedi
Digital Clock
by Wolfar15
Admin Forums
Welcome to the GuildPortal Help Community! These forums are for admin-to-admin help.
Available Forums
Forums : Feature Discussion > New popup warning when clicking an outside link.
FitzztiF (New Admin) 4/17/2008 7:46 AM EST : RE: New popup warning when clicking an outside link.
FitzztiF
Posts: 5509
Zomgawsh Poster

Ug, what a stupid change.  Thanks GP for making me take 30 minutes out of my day to hack around this.  For anyone that would like to revert links back to the non-interceptor crap, you can use the following:

Go to control panel->Style & Colors->Advanced Style Settings->Footer

In here, click the < > button for html input.  Add the code below.
Basically what this does is adds a function that undos what the new GP function does.  Anyone that looks at the source can see that GP encodes the link at the very bottom.  Using setTimeout(, 1) will cause our function to be executed 1 millisecond after page load, reverting all the links (since we can't block their encoding of them).  All my wowhead popups and off site links are back to normal.  Yell if there are any questions.

Code to add to footer:

edit: Remove the line breaks around the script command, it would let me post it with those in.

<
script language="Javascript">

function fixStupidLinks()
                  {
                    try
                    {
                        var interceptUrl = '/Outbound.aspx?Destination=';
                       
                        for (iLink=0; iLink < document.links.length; iLink++)
                        {
if( document.links[iLink].href.indexOf( interceptUrl ) != -1 )
{
  document.links[iLink].href = unescape(document.links[iLink].href.substring( document.links[iLink].href.indexOf( interceptUrl ) + interceptUrl.length)) ;

}

if( document.links[iLink].href.indexOf( "javascript:" ) == 0 )
{
document.links[iLink].target = "_self";
}
                        }
                    }
                    catch (linkExc)
                    {}
                  }
                  setTimeout("fixStupidLinks();", 1);

</script>


TopBottom

537867428_Inactive (New Admin) 4/17/2008 7:51 AM EST : RE: New popup warning when clicking an outside link.

537867428_Inactive
Posts: 2584
Zomgawsh Poster

i <3 h4XXø5z  

THANK YOU! i'll give it  shot on my site immediately.
TopBottom

FitzztiF (New Admin) 4/17/2008 7:58 AM EST : RE: New popup warning when clicking an outside link.
FitzztiF
Posts: 5509
Zomgawsh Poster

Just a bump in case someone already copied my code above, I added a check for the broken mail problem too.  It was changing the Tree View of Select From Guild Members to be an external link.  It should now catch that and set it back to opening in self.

Does this stuff get tested at all or are we just paying to be beta testers?
TopBottom

537867428_Inactive (New Admin) 4/17/2008 7:59 AM EST : RE: New popup warning when clicking an outside link.

537867428_Inactive
Posts: 2584
Zomgawsh Poster

OK.. it works.. but it has to be last scriptlet in your footer. I tried first to insert it ahead of my wowhead.com script, and it did not work.. then i moved it to the end of my footer and now it does work just fine. THANK YOU!!!
TopBottom

Ghantu (New Admin) 4/17/2008 8:24 AM EST : RE: New popup warning when clicking an outside link.
Ghantu
Posts: 237
Fingers of Fury!

It works for me too.

Have you noticed that they've made their interceptor a little dynamic? If you make a wowhead link now, it says:

Specific Link Information:
 
 # The destination site is either owned by, or is owned by a parent company that is owned by, an RMT company.
 
 # The destination site is known to have had more than one instance of a trojan/keylogger/virus outbreak.

TopBottom

537867428_Inactive (New Admin) 4/17/2008 8:28 AM EST : RE: New popup warning when clicking an outside link.

537867428_Inactive
Posts: 2584
Zomgawsh Poster

TopBottom

xandune (New Admin) 4/17/2008 8:29 AM EST : RE: New popup warning when clicking an outside link.
xandune
Posts: 826
Zomgawsh Poster

Im not too smart...what am i supposed to be removing out of that code for it to work?  Thanks!
TopBottom

FitzztiF (New Admin) 4/17/2008 8:31 AM EST : RE: New popup warning when clicking an outside link.
FitzztiF
Posts: 5509
Zomgawsh Poster

xandune said:
Im not too smart...what am i supposed to be removing out of that code for it to work?  Thanks!


<
script


needs to be all in one line

It just won't let me put it like that in the same post (gives an error)
TopBottom

xandune (New Admin) 4/17/2008 8:37 AM EST : RE: New popup warning when clicking an outside link.
xandune
Posts: 826
Zomgawsh Poster

Thanks!  got it!
TopBottom

Yage_ (New Admin) 4/17/2008 8:40 AM EST : RE: New popup warning when clicking an outside link.
Yage_
Posts: 1087
Zomgawsh Poster

FitzztiF said:
Ug, what a stupid change.  Thanks GP for making me take 30 minutes out of my day to hack around this.



Works great, thanks SO much!


TopBottom

Admins Online
There are   members online.
So-and-so has logged on!
%title%
%message%